Change compute_psats to use last crossing of Rfrac=target_level #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally got around to addressing #393 . The plot below illustrates the problem, where the p_sat calculation is thrown-off by an instability in the low-R_tes portion of the IV curve. Note that target bias voltages are not affected by this.
Also, the full P_sat distribution looks like the below. Note all the values between 0 pW and 16 pW
I then made the committed changes to the code, switching the logic from the first time R is above the target r_frac to the last time R is below the target r_frac. This fixed the psat determination in the selected detector, and it also fixed the total psat histogram to get rid of those spurious low values.
Tested on a full UHF UFM in a Princeton test cryosat.