Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move bias_step init_current_mode outside of try statement #426

Merged
merged 1 commit into from
May 13, 2024

Conversation

jlashner
Copy link
Collaborator

This moves the init_current_mode function outside of the try statement. This is a function to get the initial state of the current-mode, so we can recover. If this statement fails, since we haven't yet changed state, we don't need to run the finally block that recovers the initial state, so we don't need it inside of the try block.

Currently there are some instances where this function fails, and then the state-recovery fails since init_current_mode is not defined, such as in this discussion.

Copy link
Contributor

@msilvafe msilvafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

@jlashner jlashner requested a review from msilvafe May 13, 2024 15:40
@jlashner jlashner merged commit 514b8b1 into master May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants