Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change stream_g3_on kwarg make_freq_mask default to False #425

Merged
merged 1 commit into from
May 2, 2024

Conversation

jlashner
Copy link
Collaborator

@jlashner jlashner commented Apr 30, 2024

The make_freq_mask function involves a lot of EPICS calls and takes a long time to run. This is currently causing some issues on SAT1, and as far as I know the resulting "freq.txt" file is not use anywhere in SO.

This changes the stream defaults so that it does not attempt to make a frequency mask.

Copy link
Contributor

@msilvafe msilvafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good investigation, are you sure that none of the data packaging operations use the mask file that's written? Is there a test we can run off this branch before we merge to check double check that nothing downstream needs that? If you've checked and are pretty confident that nothing downstream uses this I'm ok just merging.

@jlashner
Copy link
Collaborator Author

Just checked and this is the only instance of freq.txt in all of sotodlib, so I think we should be ok to remove it without testing: https://github.com/simonsobs/sotodlib/blob/1e85b2c3a41c329cb396cd278a81fa3a05e48ee7/sotodlib/io/imprinter.py#L677-L679

@msilvafe
Copy link
Contributor

Just checked and this is the only instance of freq.txt in all of sotodlib, so I think we should be ok to remove it without testing: https://github.com/simonsobs/sotodlib/blob/1e85b2c3a41c329cb396cd278a81fa3a05e48ee7/sotodlib/io/imprinter.py#L677-L679

Ok thanks for double checking.

@jlashner jlashner merged commit eaa66cc into master May 2, 2024
1 check passed
@jlashner jlashner deleted the stream-defaults branch May 3, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants