Adds relock_tracking_setup after setup_tracking_params finishes #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @yuhanwyhan and @yaqiongl described in #372,
setup_tracking_params
leaves you in a bad state, where the tracking is only optimized for the last band run, which can lead to high noise on AMC0 since thelms_freqs
may not be set correctly.I believe the best way to fix this is to run
relock_tracking_setup
after finding the tracking params for each band, which will chose afrac_pp
based on the optimal params for each of the running bands, and will adjustlms_freq
for each band accordingly. I have been running this manually whenever I setup_tracking_params and I think it works well, but it makes sense to just build it into the function.