Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds relock_tracking_setup after setup_tracking_params finishes #388

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

jlashner
Copy link
Collaborator

@jlashner jlashner commented Sep 3, 2023

As @yuhanwyhan and @yaqiongl described in #372, setup_tracking_params leaves you in a bad state, where the tracking is only optimized for the last band run, which can lead to high noise on AMC0 since the lms_freqs may not be set correctly.

I believe the best way to fix this is to run relock_tracking_setup after finding the tracking params for each band, which will chose a frac_pp based on the optimal params for each of the running bands, and will adjust lms_freq for each band accordingly. I have been running this manually whenever I setup_tracking_params and I think it works well, but it makes sense to just build it into the function.

Copy link
Contributor

@msilvafe msilvafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your changes. And given you've been running like this for awhile I think it's safe to merge.

@jlashner jlashner merged commit 17f3c21 into master Jan 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants