Fan control #387
Merged
Fan control #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msilvafe
approved these changes
Sep 2, 2023
hammers/jackhammer
Outdated
| if 'smurf_fans' not in sys_config: | ||
| # Old way of setting up fans | ||
| cprint( | ||
| "'fans' key not found in sys config. Setting fan levels using " |
There was a problem hiding this comment.
Should print ‘smurf_fans’ not ‘fans’ key
hammers/jackhammer
Outdated
| start_sync_parser = subparsers.add_parser('start-sync') | ||
| start_sync_parser.set_defaults(func=start_sync_func) | ||
|
|
||
| ########### Jackhammer start-sync parser ########### |
There was a problem hiding this comment.
Should this comment be setup-fans parser?
| @@ -260,7 +260,7 @@ def plot_channel_resonance(S, cfg, band, chan): | |||
|
|
|||
| @sdl.set_action() | |||
| def uxm_relock( | |||
| S: SmurfControl, cfg, bands=None, show_plots=False, | |||
| S, cfg, bands=None, show_plots=False, | |||
There was a problem hiding this comment.
This seems unrelated to this PR but ok…
There was a problem hiding this comment.
This was required for me to get docs to build... I may invest some time cleaning up the docs and making sure everything is up to date.
|
Tested at site so I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more in-depth fan-control to jackhammer, to allow us to set the fan-policy and fan speeds, and added docs.
This will allow us to configure smurf to run fixed at the max fan-speed if we want, based on discussion #354