Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Rfrac plot when bias steps are taken and run_analysis=True #345

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Create Rfrac plot when bias steps are taken and run_analysis=True #345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a98a80
Create Rfrac plot when bias steps are taken and run_analysis=True
msilvafe May 25, 2023
ea0b855
Add arg for plotting, add saving, default bgmap to not plot.
msilvafe May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions sodetlib/operations/bias_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,9 +1001,8 @@ def plot_Rfrac(bsa, text_loc=(0.6, 0.8)):
def take_bgmap(S, cfg, bgs=None, dc_voltage=0.3, step_voltage=0.01,
step_duration=0.05, nsteps=20, high_current_mode=True,
hcm_wait_time=0, analysis_kwargs=None, dacs='pos',
use_waveform=True, show_plots=True,g3_tag=None,
enable_compression=False):

use_waveform=True, show_plots=True, g3_tag=None,
enable_compression=False, plot_rfrac=False):
"""
Function to easily create a bgmap. This will set all bias group voltages
to 0 (since this is best for generating the bg map), and run bias-steps
Expand Down Expand Up @@ -1051,6 +1050,10 @@ def take_bgmap(S, cfg, bgs=None, dc_voltage=0.3, step_voltage=0.01,
If True, will tell the smurf-streamer to compress G3Frames. Defaults
to False because this dominates frame-processing time for high
data-rate streams.
plot_rfrac : bool
Create rfrac plot, publish it, and save it. Default is False.
show_plots : bool
Show plot in addition to saving when running interactively. Default is False.
"""
if bgs is None:
bgs = cfg.dev.exp['active_bgs']
Expand All @@ -1072,7 +1075,8 @@ def take_bgmap(S, cfg, bgs=None, dc_voltage=0.3, step_voltage=0.01,
nsteps=nsteps, high_current_mode=high_current_mode,
hcm_wait_time=hcm_wait_time, run_analysis=True, dacs=dacs,
use_waveform=use_waveform, g3_tag=g3_tag, stream_subtype='bgmap',
analysis_kwargs=_analysis_kwargs, enable_compression=enable_compression,
plot_rfrac=plot_rfrac, show_plots=show_plots,
enable_compression=enable_compression, analysis_kwargs=_analysis_kwargs
)

if hasattr(bsa, 'bgmap'):
Expand All @@ -1094,7 +1098,8 @@ def take_bias_steps(S, cfg, bgs=None, step_voltage=0.05, step_duration=0.05,
nsteps=20, high_current_mode=True, hcm_wait_time=3,
run_analysis=True, analysis_kwargs=None, dacs='pos',
use_waveform=True, channel_mask=None, g3_tag=None,
stream_subtype='bias_steps', enable_compression=False):
stream_subtype='bias_steps', enable_compression=False,
plot_rfrac=True, show_plots=False):
"""
Takes bias step data at the current DC voltage. Assumes bias lines
are already in low-current mode (if they are in high-current this will
Expand Down Expand Up @@ -1150,6 +1155,10 @@ def take_bias_steps(S, cfg, bgs=None, step_voltage=0.05, step_duration=0.05,
If True, will tell the smurf-streamer to compress G3Frames. Defaults
to False because this dominates frame-processing time for high
data-rate streams.
plot_rfrac : bool
Create rfrac plot, publish it, and save it. Default is True.
show_plots : bool
Show plot in addition to saving when running interactively. Default is False.
"""
if bgs is None:
bgs = cfg.dev.exp['active_bgs']
Expand Down Expand Up @@ -1220,6 +1229,13 @@ def take_bias_steps(S, cfg, bgs=None, step_voltage=0.05, step_duration=0.05,
if analysis_kwargs is None:
analysis_kwargs = {}
bsa.run_analysis(save=True, **analysis_kwargs)
if plot_rfrac:
fig, ax = plot_Rfrac(bsa)
path = sdl.make_filename(S, 'bs_rfrac_summary.png', plot=True)
fig.savefig(path)
S.pub.register_file(path, 'bs_rfrac_summary', plot=True, format='png')
if not show_plots:
plt.close(fig)
except Exception:
print(f"Bias step analysis failed with exception:")
print(traceback.format_exc())
Expand Down
Loading