Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTSP Camera Agent: fix docker dependency and make copy for latest file #800

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

davidvng
Copy link
Contributor

@davidvng davidvng commented Dec 9, 2024

Description

  • Added opencv-python-headless dependency to Dockerfile
  • Make a copy of latest file instead of creating symlink

Motivation and Context

  • opencv-python only works for local installations, need headless version for Docker
  • Symlinks not valid outside of docker container

How Has This Been Tested?

Tested on daq-dev

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some thoughts on possible configs that wouldn't require changes to the symlink section below.

socs/common/camera.py Outdated Show resolved Hide resolved
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@BrianJKoopman BrianJKoopman merged commit 7631d0e into main Dec 10, 2024
5 checks passed
@BrianJKoopman BrianJKoopman deleted the rtsp-camera-fix branch December 10, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants