Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'fake_data' arg for random data generation #776

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

BrianJKoopman
Copy link
Member

Description

This PR removes the random data generation provided by the 'fake_data' argument in the 372 agent.

Motivation and Context

Been meaning to remove this for a while now. This isn't need anymore. We have the 372 simulator which allows testing this agent against some random data if needed.

Also removes an extra layer of the already heavily nested acq() method.

How Has This Been Tested?

I've run the tests locally, which all pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Been meaning to remove this for a while now. This isn't need anymore. We also
have the 372 simulator which allows testing this agent against some random
data.
@BrianJKoopman BrianJKoopman added cleanup repo/code cleanup agent: ls372 labels Oct 16, 2024
@BrianJKoopman BrianJKoopman merged commit 40c3d72 into main Oct 16, 2024
5 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/remove-372-fake-data branch October 16, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent: ls372 cleanup repo/code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant