Convert LS372 class to TCPInterface subclass #775
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This better mimics the socket API, which developers looking to use TCP might already be familiar with.
Default to 4096, the reasonable example value from upstream docs, which is commonly used in existing agents.
BrianJKoopman
force-pushed
the
koopman/tcp-device-interface-class
branch
from
527498a to
97d00a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This converts the
LS372class to be a subclass of the newTCPInterfaceclass introduced in #769.Motivation and Context
Resolves #774.
This also is a good demonstration of the use of the
TCPInterfacesubclass beyond the initial Cryomech Agent example.How Has This Been Tested?
Not yet tested, needs to be tested against the actual hardware in dropout scenarios. Will submit as draft until then.
Types of changes
Checklist: