Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug the wiregrid_tiltsensor agent #764

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

d-hoshino2626
Copy link
Contributor

@d-hoshino2626 d-hoshino2626 commented Sep 29, 2024

Description

I changed the wiregrid_tiltsensor agent and moxa_serial.py in the socs/common directory.
In the wiregrid_tiltsensor, I removed the type of argument from add_argument and added cast of the port.
In the moxa_serial.py, I added new argument, device=kikusui, to the class Serial_TCPServer. This argument is for recognize which device the serial-to-LAN converter communicate with. The tilt sensor needs to send commands not decoded and recieve commands not encoded. This change detect the device to communicate and judge the neccesity of encoding and decoding of commands.

Motivation and Context

To debug the wiregrid_tiltsensor agent.

Resolves #716.

How Has This Been Tested?

Tested in my lab, using a serial-to-LAN converter.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for working on this! A couple small comments to address below.

socs/agents/wiregrid_tiltsensor/agent.py Outdated Show resolved Hide resolved
socs/common/moxa_serial.py Outdated Show resolved Hide resolved
@d-hoshino2626
Copy link
Contributor Author

Thanks, Brian!
I changed according to your comment and checked this change working well in our lab.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Brian! I changed according to your comment and checked this change working well in our lab.

Looks great, thanks for the updates!

@BrianJKoopman BrianJKoopman merged commit e225002 into main Oct 7, 2024
5 checks passed
@BrianJKoopman BrianJKoopman deleted the debug_wiregrid_tiltsensor branch October 7, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error connecting to DWL tilt sensor
2 participants