fixing minor issues in scpi_psu and bluefors agents #763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log result of scpi_psu's get_output task always returned 'disabled' even when it was actually enabled; bluefors agent not recognizing log file types based on capitalization (e.g. Heaters vs. heaters)
Description
For SCPI_PSU: set the
enabled
variable based on the outcome of the get_output() driver function. This was the original intent, but the check was lost during rearranging of the session data structure.For bluefors:
Added the
flags=re.I
option to each of the regex checks to make them case-insensitive.Motivation and Context
For SCPI_PSU: The change is mostly for debugging. The correct state of the output was already being reported in the session data, but the log output wasn't properly reflecting this.
For bluefors: The new Bluefors Temperature Controller saves the Heaters log files with a capital 'H' whereas Lakeshore is lower-case. The contents and other formatting is identical however. This change should now treat both cases the same.
How Has This Been Tested?
Attempted to run
python3 -m pytest --cov
but execution seem to hang at the HWP Supervisor.Otherwise, the only testing has been with our lab's setup:
Influxdb Agent
Aggregator Agent
Bluefors Agent
SCPI PSU Agent
Fakedata Agent
Labjack Agent
Cryomech CPA Agent
Types of changes
Checklist: