Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing minor issues in scpi_psu and bluefors agents #763

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CAWNoodle
Copy link
Contributor

log result of scpi_psu's get_output task always returned 'disabled' even when it was actually enabled; bluefors agent not recognizing log file types based on capitalization (e.g. Heaters vs. heaters)

Description

For SCPI_PSU: set the enabled variable based on the outcome of the get_output() driver function. This was the original intent, but the check was lost during rearranging of the session data structure.

For bluefors:
Added the flags=re.I option to each of the regex checks to make them case-insensitive.

Motivation and Context

For SCPI_PSU: The change is mostly for debugging. The correct state of the output was already being reported in the session data, but the log output wasn't properly reflecting this.

For bluefors: The new Bluefors Temperature Controller saves the Heaters log files with a capital 'H' whereas Lakeshore is lower-case. The contents and other formatting is identical however. This change should now treat both cases the same.

How Has This Been Tested?

Attempted to run python3 -m pytest --cov but execution seem to hang at the HWP Supervisor.

Otherwise, the only testing has been with our lab's setup:
Influxdb Agent
Aggregator Agent
Bluefors Agent
SCPI PSU Agent
Fakedata Agent
Labjack Agent
Cryomech CPA Agent

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

'disabled'; bluefors agent not recognizing log file types based on
capitalization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant