Inconsequential correction to IFM SBN246 temperature decode. #761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think the decode of the temperature data from the IFM SBN246 sensor drops the MSB here;
socs/socs/agents/ifm_sbn246_flowmeter/agent.py
Line 29 in 81e5916
From the IO-Link process data description;
but running a 32-bit word through the existing code;
gives
which misses the MSB of the temperature process data field (letter 'q' here). This PR fixes that.
Motivation and Context
In my lab this makes no difference, probably because it would only matter if the temperatures were much higher. The same is almost certainly true in the field. This change probably doesn't matter, I just noticed it when I was working out the decode for a different IFM sensor.
How Has This Been Tested?
I compiled and tested on my two SBN246 sensors in my lab at SLAC and it made no difference.
Types of changes
Checklist: