Support random availble port selection in DeviceEmulator #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlashner
approved these changes
Mar 15, 2024
|
This doesn't actually solve the problem in #633, so I might hold off on merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for binding to a random available port when using the 'tcp' relay in the
DeviceEmulator. This is now the default behavior. Tests that use this will need to grab the bound port viaemulator.portto connect to.Motivation and Context
This should fix the issue with flaky moxa tests seen in #633.
How Has This Been Tested?
Tested locally with the modifications to the tests here.
Types of changes
Checklist: