Adding Hi6200 Agent for reading LN2 on SATp #555
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Thanks for the PR @mjrand!
In addition to the inline comments below, this agent needs a docs page. Please add a page for it under docs/agents/. For the page to show up, it must be added to the index file. There are instructions for building the docs here.
…val of all swap files
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Thanks for the updates @mjrand. A few more comments and responses to some of the modifications below.
|
whoops I forgot to actually incorporate half the comments.... give me a little bit to go through them before reviewing |
…ding function, etc.
|
Fixed comments, agent works and is ready for review. |
There was a problem hiding this comment.
Hi @mjrand, thanks for the updates! (And sorry this has sat for so long.) It's looking good, I think we're basically ready to merge.
I added the docs page to the index, and then cleaned up some formatting of docstrings, mostly in the drivers. I also did some very minor restructuring in the agent to remove a layer of indents and add some info to the locks (though I don't really expect any locking issues here with only one task and one process...) Other changes were mostly wrapping long lines as I reviewed.
I'll plan to merge at the beginning of next week (avoiding doing so as it approaches 5pm on a Friday.) Let me know if you have any concerns.
* Adding Hi6200 Agent for reading LN2 on SATp * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Corrected some whitespace and style issues * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed my fight with the pre-commit bot * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added in edits from Brian's PR comments. Added docs. (Attempted) removal of all swap files * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Attempting to fix disconnect error catching * Added catch in monitor weight for AttributeError. Cleaned up code as per Brian's comments. * Actually fixed Brian's comments regarding pacemaker, privatizing decoding function, etc. * Remove layer of nesting in main process * Add job names to lock * Wrap agent code to 80 characters * Add agent to docs index * Add driver code to docs page * Format driver docstrings and wrap code to 80 characters --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Brian Koopman <[email protected]>
Description
Added the agent.py and driver.py files for the hi6200 agent in socs.
Motivation and Context
This agent controls the hi6200 weight controller that reads the scale measuring the LN2 depth on SATp1.
How Has This Been Tested?
I tested this in daq-dev and was able to verify the agent ran and uploaded data correctly.
Types of changes
Checklist: