Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow floats for custom PID task arguments #548

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

BrianJKoopman
Copy link
Member

Description

Title says it all.

Motivation and Context

There isn't really a reason to restrict these to int. @mhasself pointed this out as he prepared ocs-web's interface for submitting params.

How Has This Been Tested?

It has not been tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman merged commit 7aad264 into main Oct 16, 2023
2 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/372-custom-pid-datatypes branch October 16, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant