Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds general task to set TES biases #545

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Conversation

jlashner
Copy link
Collaborator

Adds a general task to set tes biases to specified values, and a separate task to zero biases. Resolves #544.

Description

Adds a needed function to the pysmurf-controller set_biases that lets you generally set tes biases. Also adds zero_biases task which can makes it easier to zero all biases from OCS web.

Motivation and Context

We need more control over TES biases from pysmurf-controller.

How Has This Been Tested?

Not tested yet.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman self-requested a review October 12, 2023 18:36
@kmharrington
Copy link
Member

We could really use these functions running in the field. What's needed to get it going there?

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, mostly docstring related requests.

socs/agents/pysmurf_controller/agent.py Show resolved Hide resolved
socs/agents/pysmurf_controller/agent.py Outdated Show resolved Hide resolved
socs/agents/pysmurf_controller/agent.py Outdated Show resolved Hide resolved
socs/agents/pysmurf_controller/agent.py Show resolved Hide resolved
@jlashner
Copy link
Collaborator Author

jlashner commented Nov 7, 2023

sorry that took so long, but addressed @BrianJKoopman's feedback

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@BrianJKoopman BrianJKoopman merged commit ff3a1d6 into main Nov 7, 2023
5 checks passed
@BrianJKoopman BrianJKoopman deleted the pysmurf_set_biases branch November 7, 2023 16:57
hnakata-JP pushed a commit that referenced this pull request Apr 12, 2024
* Adds general task to set TES biases

* Adds zero_biases task

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix typo

* address brian's comments

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Brian Koopman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability turn detector bias off in pysmurf controller
3 participants