ACU -- updates to work with LAT #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other fixes to work on the LAT; some simplifications
for more information, see https://pre-commit.ci
The scan generator code was adding an extra "step_time" (usually 1s) to each turn-around.
|
I have just added the "az_drift" parameter to generate_scan. Also this whole deal has now been tested on a SATP without any issues. |
BrianJKoopman
requested changes
Sep 19, 2023
BrianJKoopman
approved these changes
Sep 19, 2023
|
Thanks for the update, will merge once checks pass. |
hnakata-JP
pushed a commit
that referenced
this pull request
Apr 12, 2024
* ACU: cmdline switch to not start monitor/broadcast * ACU: corotator data are tagged as "Corotator" instead of "Axis3" Other fixes to work on the LAT; some simplifications * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * ACU: fix turn-around time computation The scan generator code was adding an extra "step_time" (usually 1s) to each turn-around. * ACU: remove az_min / az_max in preparation for az_drift * ACU: add az_drift parameter to scan generator * ACU: add az_drift to agent * ACU: document startup arg --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables basic LAT co-rotator control and readout. A couple of minor improvements come along for the ride.
These are fairly minor changes; there are more important fixes in the latest versions of soaculib and ocs-web. Those should be up to date to take full advantage of LAT.
How Has This Been Tested?
This is the result of direct testing on the LAT.
Types of changes
Checklist: