Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rolling deletion background task #114

Merged
merged 12 commits into from
Dec 5, 2024
Merged

Rolling deletion background task #114

merged 12 commits into from
Dec 5, 2024

Conversation

JBorrow
Copy link
Member

@JBorrow JBorrow commented Nov 14, 2024 •
edited
Loading

Closes #111

This adds a rolling background task that allows you to delete files in the local librarian subject to constraints:

  1. There must be n copies offsite elsewhere in the (downstream) network
  2. Those copies must have valid checksums
  3. Those instances are at least m days old

@JBorrow JBorrow marked this pull request as ready for review November 15, 2024 16:50
BrianJKoopman
BrianJKoopman reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. A couple of small comments inline below.

librarian_background/rolling_deletion.py Outdated Show resolved Hide resolved
librarian_background/rolling_deletion.py Show resolved Hide resolved
tests/background_unit_test/test_rolling_deletion.py Outdated Show resolved Hide resolved
@JBorrow JBorrow merged commit 4e97175 into main Dec 5, 2024
5 checks passed
@JBorrow JBorrow deleted the JBorrow/issue111 branch December 5, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iparask iparask iparask left review comments

@BrianJKoopman BrianJKoopman BrianJKoopman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add automated/rolling deletion
3 participants
@JBorrow @BrianJKoopman @iparask