Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for flat notes, fix wrong position and frequency #39

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

simonppg
Copy link
Owner

@simonppg simonppg commented Jun 3, 2024

No description provided.

Copy link

github-actions bot commented Jun 3, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
98.89% (+0.59% 🔼)
178/180
🟢 Branches
94.34% (+0.22% 🔼)
50/53
🟢 Functions
97.73% (+2.27% 🔼)
43/44
🟢 Lines
98.84% (+0.62% 🔼)
170/172

Test suite run success

40 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 9a3c2fa

Copy link

github-actions bot commented Jun 3, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
lib/Accidental.d.ts, lib/Accidental.js, lib/Accidental.js.map, lib/Chord.d.ts, lib/Chord.js, lib/Chord.js.map, lib/ChordsFormula.d.ts, lib/ChordsFormula.js, lib/ChordsFormula.js.map, lib/Frequency.d.ts, lib/Frequency.js, lib/Frequency.js.map, lib/IntervalPattern.d.ts, lib/IntervalPattern.js, lib/IntervalPattern.js.map, lib/Main.d.ts, lib/Main.js, lib/Main.js.map, lib/Math.d.ts, lib/Math.js, lib/Math.js.map, lib/Note.d.ts, lib/Note.js, lib/Note.js.map, lib/NoteDTO.d.ts, lib/NoteDTO.js, lib/NoteDTO.js.map, lib/NoteParser.d.ts, lib/NoteParser.js, lib/NoteParser.js.map, lib/NoteValidator.d.ts, lib/NoteValidator.js, lib/NoteValidator.js.map, lib/Scale.d.ts, lib/Scale.js, lib/Scale.js.map, lib/ScaleFormatter.d.ts, lib/ScaleFormatter.js, lib/ScaleFormatter.js.map, lib/ScalesCode.d.ts, lib/ScalesCode.js, lib/ScalesCode.js.map, lib/math/Binary.d.ts, lib/math/Binary.js, lib/math/Binary.js.map 12.87 KB (+0.45% 🔺) 258 ms (+0.45% 🔺) 800 ms (+2.83% 🔺) 1.1 s

@simonppg simonppg merged commit e668bc3 into main Jun 3, 2024
13 of 16 checks passed
@simonppg simonppg deleted the flatNotesSupport branch June 3, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant