Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Accidentals on Note class #38

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Use Accidentals on Note class #38

merged 1 commit into from
Jun 2, 2024

Conversation

simonppg
Copy link
Owner

@simonppg simonppg commented Jun 2, 2024

No description provided.

Copy link

github-actions bot commented Jun 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
lib/Accidental.d.ts, lib/Accidental.js, lib/Accidental.js.map, lib/Chord.d.ts, lib/Chord.js, lib/Chord.js.map, lib/ChordsFormula.d.ts, lib/ChordsFormula.js, lib/ChordsFormula.js.map, lib/Frequency.d.ts, lib/Frequency.js, lib/Frequency.js.map, lib/IntervalPattern.d.ts, lib/IntervalPattern.js, lib/IntervalPattern.js.map, lib/Main.d.ts, lib/Main.js, lib/Main.js.map, lib/Math.d.ts, lib/Math.js, lib/Math.js.map, lib/Note.d.ts, lib/Note.js, lib/Note.js.map, lib/NoteDTO.d.ts, lib/NoteDTO.js, lib/NoteDTO.js.map, lib/NoteParser.d.ts, lib/NoteParser.js, lib/NoteParser.js.map, lib/NoteValidator.d.ts, lib/NoteValidator.js, lib/NoteValidator.js.map, lib/Scale.d.ts, lib/Scale.js, lib/Scale.js.map, lib/ScaleFormatter.d.ts, lib/ScaleFormatter.js, lib/ScaleFormatter.js.map, lib/ScalesCode.d.ts, lib/ScalesCode.js, lib/ScalesCode.js.map, lib/math/Binary.d.ts, lib/math/Binary.js, lib/math/Binary.js.map 12.81 KB (+0.23% 🔺) 257 ms (+0.23% 🔺) 718 ms (+2.4% 🔺) 974 ms

Copy link

github-actions bot commented Jun 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
98.3% (+2.25% 🔼)
173/176
🟢 Branches
94.12% (+3.21% 🔼)
48/51
🟢 Functions
95.45% (+4.55% 🔼)
42/44
🟢 Lines
98.21% (+2.36% 🔼)
165/168
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢 Note.ts
97.5% (-2.5% 🔻)
92.31% (-7.69% 🔻)
100%
97.5% (-2.5% 🔻)

Test suite run success

40 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 4c8fd99

@simonppg simonppg merged commit 0fa3208 into main Jun 2, 2024
10 of 11 checks passed
@simonppg simonppg deleted the NoteAccidentals branch June 2, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant