Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chords #17

Merged
merged 25 commits into from
Sep 13, 2023
Merged

Chords #17

merged 25 commits into from
Sep 13, 2023

Conversation

simonppg
Copy link
Owner

No description provided.

@simonppg
feat(scale): Add Scale class
0a824bf
@simonppg
feat(scale): Re-use methods
6524a8e
@simonppg
feat(scale): Calculate modes
a8178cc
@simonppg
refactor(scale): Remove warning
4ec2bca
@simonppg
refactor(scale): Make Scales.ts constants
a75e42c
@simonppg
fix(scale): Remove warning
245da5d
@simonppg
feat(scale): Add more scales
5df1d73
@simonppg
feat(scale): Add scale degrees
3aae3d6
@simonppg
feat(scale): Calculate degrees and modes
60136e3
@simonppg
test(scale): Test C# Mayor scale degrees and modes
e74552c
@simonppg
test(scale): Test C Major pentatonic scale
ad8d61a
@simonppg
test(scale): Remove unused files
4591c8c
@simonppg
ci(linter): Do not lint files inside test folder
eae4a0a
@simonppg
Merge remote-tracking branch 'origin/main' into Scales
579a0fb
@simonppg
build(tsc): Import and export everything on Main.ts
f7ed67e
@simonppg
docs(README): Add how to use Scale
b8ae948
@simonppg
docs(README): Document Scale methods
87e41de
@simonppg
feat(chord): Generate major chords
d5df69c
@github-actions
Copy link

github-actions bot commented Jul 16, 2022 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 100% 124/124
🟢 Branches 100% 35/35
🟢 Functions 100% 34/34
🟢 Lines 100% 119/119
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢 Scale.ts 100% 100% 100% 100%
🟢 Scales.ts 100% 100% 100% 100%
🟢 Chord.ts 100% 100% 100% 100%
🟢 ChordsFormula.ts 100% 100% 100% 100%

Test suite run success

27 tests passing in 6 suites.

Report generated by 🧪jest coverage report action from fd47599

@github-actions
Copy link

github-actions bot commented Jul 17, 2022 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
lib/Chord.d.ts, lib/Chord.js, lib/Chord.js.map, lib/ChordsFormula.d.ts, lib/ChordsFormula.js, lib/ChordsFormula.js.map, lib/Frequency.d.ts, lib/Frequency.js, lib/Frequency.js.map, lib/Main.d.ts, lib/Main.js, lib/Main.js.map, lib/Math.d.ts, lib/Math.js, lib/Math.js.map, lib/Note.d.ts, lib/Note.js, lib/Note.js.map, lib/NoteValidator.d.ts, lib/NoteValidator.js, lib/NoteValidator.js.map, lib/Scale.d.ts, lib/Scale.js, lib/Scale.js.map, lib/Scales.d.ts, lib/Scales.js, lib/Scales.js.map 7.89 KB (+7.48% 🔺) 158 ms (+7.48% 🔺) 4.4 s (+10.22% 🔺) 4.6 s

@github-actions
Copy link

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 100% 124/124
🟢 Branches 100% 35/35
🟢 Functions 100% 34/34
🟢 Lines 100% 118/118
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢 Scale.ts 100% 100% 100% 100%
🟢 Scales.ts 100% 100% 100% 100%
🟢 Chord.ts 100% 100% 100% 100%
🟢 ChordsFormula.ts 100% 100% 100% 100%

Test suite run success

27 tests passing in 6 suites.

Report generated by 🧪jest coverage report action from f2c87a6

@simonppg simonppg merged commit 2728067 into main Sep 13, 2023
9 checks passed
@simonppg simonppg deleted the Chords branch September 13, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simonppg