Changes for FNAL TB 2023 #23
Conversation
…he WFClassClock and add the preprocessor functionality
DynamicTTree
Outdated
There was a problem hiding this comment.
These changed should be pushed to the submodule repo: https://github.com/simonepigazzini/DynamicTTree and not directly here. In H4analysis we should just change the commit to which the submodule point to.
There was a problem hiding this comment.
I will push also there, but this pull request needs to know which version of DynamicTree to be used
|
Forgot to mention, that I've briefly tested this branch on a previous H4Tree config and everything should be bwk compatible (default dataType and preprocessor is set to H4Tree) +++ Adding file /eos/cms/store/group/dpg_ecal/comm_ecal/upgrade/testbeam/ECALTB_H4_Oct2021/DataTree/15001/0035.root
The only thing is a warning for digiSampleTime missing, as I've added this branch to directly fill time from FNAL scope data, as it seem to come from some scope calibration (it's not regularly spaced) |
-> Adding preprocessor (needed to read directly FNAL TB data). Previous configs should be fully backward compatibles
-> Dynamic tree has been fixed to specificy MAX_SIZE when not creating H4Tree from a TTree. Fixed also a bug for unsigned long long not present in the typeId map (separate pull request to DynamicTree for this)
-> Possibility to run without a trgInstance (using PHYS as standard trig Type)
-> Several improvements to the WFClassClock: baseline subtraction from a templatefit, inclusion of polarity (to also use trailing edge for independent clock measurement)
-> WFCLass CropWF: create a cropped copy of another WFClass, can be used to create indipendent shorter copies of the original WF (eg for clock phase precision estimation)