add limit offset

drift_dev/lib/src/lints/custom_lint_plugin.dart

@@ -1,11 +1,15 @@
 import 'package:custom_lint_builder/custom_lint_builder.dart';
+import 'package:drift_dev/src/lints/offset_without_limit.dart';
 import 'package:drift_dev/src/lints/drift_backend_errors.dart';
 import 'package:drift_dev/src/lints/unawaited_futures_in_transaction.dart';
 import 'package:meta/meta.dart';
 
 @internal
 class DriftLinter extends PluginBase {
   @override
-  List<LintRule> getLintRules(CustomLintConfigs configs) =>
-      [UnawaitedFuturesInTransaction(), DriftBuildErrors()];
+  List<LintRule> getLintRules(CustomLintConfigs configs) => [
+        UnawaitedFuturesInTransaction(),
+        DriftBuildErrors(),
+        OffsetWithoutLimit()
+      ];
 }

drift_dev/lib/src/lints/offset_without_limit.dart

@@ -0,0 +1,60 @@
+import 'dart:io';
+
+import 'package:analyzer/dart/analysis/results.dart';
+import 'package:analyzer/dart/analysis/session.dart';
+import 'package:analyzer/dart/ast/ast.dart';
+import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/error/error.dart' hide LintCode;
+import 'package:analyzer/error/listener.dart';
+import 'package:custom_lint_builder/custom_lint_builder.dart';
+import 'package:drift_dev/src/analysis/backend.dart';
+import 'package:drift_dev/src/analysis/options.dart';
+import 'package:logging/logging.dart';
+
+import '../analysis/driver/driver.dart';
+
+final managerTypeChecker =
+    TypeChecker.fromName('BaseTableManager', packageName: 'drift');
+
+class OffsetWithoutLimit extends DartLintRule {
+  OffsetWithoutLimit() : super(code: _code);
+
+  static const _code = LintCode(
+    name: 'offset_without_limit',
+    problemMessage: 'Using offset without a limit will result in a ',
+    errorSeverity: ErrorSeverity.ERROR,
+  );
+
+  @override
+  void run(CustomLintResolver resolver, ErrorReporter reporter,
+      CustomLintContext context) async {
+    context.registry.addMethodInvocation(
+      (node) {
+        if (node.argumentList.arguments.isEmpty) return;
+        final func = _typeCheck<SimpleIdentifier>(node.function);
+
+        if (func?.name == "get" || func?.name == "watch") {
+          final target = _typeCheck<PrefixedIdentifier>(node.target);
+          final managerGetter =
+              _typeCheck<PropertyAccessorElement>(target?.staticElement);
+          if (managerGetter != null) {
+            if (managerTypeChecker.isSuperTypeOf(managerGetter.returnType)) {
+              final namedArgs =
+                  node.argumentList.arguments.whereType<NamedExpression>();
+              if (namedArgs
+                      .every((element) => element.name.label.name != "limit") &&
+                  namedArgs
+                      .any((element) => element.name.label.name == "offset")) {
+                reporter.atNode(node, _code);
+              }
+            }
+          }
+        }
+      },
+    );
+  }
+}
+
+T? _typeCheck<T>(i) {
+  return i is T ? i : null;
+}

drift_dev/test/linter_test/pkg/lib/db.dart

@@ -7,6 +7,8 @@ class Users extends Table {
   late final name = text()();
   // expect_lint: drift_build_errors
   late final age = integer();
+  // ignore: drift_build_errors
+  late final age2 = integer()();
 }
 
 class BrokenTable extends Table {
@@ -22,6 +24,17 @@ class TestDatabase extends _$TestDatabase {
   int get schemaVersion => 1;
 
   a() async {
+    // expect_lint: offset_without_limit
+    managers.users.get(offset: 1);
+    // expect_lint: offset_without_limit
+    managers.users.watch(offset: 1);
+    managers.users.get();
+    managers.users.get(distinct: true);
+    managers.users.get(limit: 1);
+    managers.users.get(limit: 1, distinct: true);
+    managers.users.get(limit: 1, offset: 1);
+    managers.users.get(limit: 1, offset: 1, distinct: true);
+
     transaction(
       () async {
         // expect_lint: unawaited_futures_in_transaction
@@ -30,3 +43,11 @@ class TestDatabase extends _$TestDatabase {
     );
   }
 }
+
+class A {
+  void get() {}
+}
+
+void a() {
+  A().get();
+}

drift_dev/test/linter_test/pkg/pubspec.yaml

@@ -1,16 +1,12 @@
 name: linter_test
-description: A starting point for Dart libraries or applications.
 version: 1.0.0
-# repository: https://github.com/my_org/my_repo
 
 environment:
   sdk: ^3.5.3
 
-# Add regular dependencies here.
 dependencies:
   drift:
   build_runner: ^2.4.13
-  # path: ^1.8.0
 
 dev_dependencies:
   lints: ^4.0.0