-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVX512F/fmaddsub: Implement Instruction #1246
AVX512F/fmaddsub: Implement Instruction #1246
Conversation
This looks like the correct direction, yes! Please review the linter / formating results at https://github.com/simd-everywhere/simde/actions/runs/12282344329/job/34273355555?pr=1246 You'll also need an entry for Lines 70 to 74 in fa6a869
See also https://github.com/simd-everywhere/simde/wiki/Implementing-a-New-Function for hints about generating the tests. I can also help you with that. |
I'll try to add the tests later today |
This pipeline is massive... But looking good so far. Anything else I need to adjust? |
@robinchrist the CI is looking good! Did you generate the test arrays on a machine that supports AVX512F? If not, let me know and I'll run them on real hardware. The CI uses an emulator from Intel, but I like to double check with real silicon. |
@mr-c All my AVX512 machines are currently not available, so if possible it would be good if you tested on a CPU with native AVX512. If not possible, I‘ll try to get one of my Cascade Lake machines up and running this weekend |
@robinchrist I ran the tests on a |
@mr-c Amazing, thanks a lot! So I guess we're ready to merge now? |
@robinchrist Nearly there! I'll merge after a few more CIs pass |
First implementation of AVX512 fmaddsub (
_mm512_fmaddsub_pd
and_mm512_fmaddsub_ps
), see #1243Current status:
No tests yet. This is just to see whether the header itself could be merged style-wise.