avx512 abs: refine GCC compiler checks for _mm512{,_mask}_abs_pd
#1118
Conversation
simde/x86/avx512/abs.h
Outdated
| @@ -524,7 +524,7 @@ simde_mm512_mask_abs_ps(simde__m512 src, simde__mmask16 k, simde__m512 v2) { | |||
| SIMDE_FUNCTION_ATTRIBUTES | |||
| simde__m512d | |||
| simde_mm512_abs_pd(simde__m512d v2) { | |||
| #if defined(SIMDE_X86_AVX512F_NATIVE) && (!defined(HEDLEY_GCC_VERSION) || HEDLEY_GCC_VERSION_CHECK(8,3,0)) | |||
| #if defined(SIMDE_X86_AVX512F_NATIVE) && (!defined(HEDLEY_GCC_VERSION) || (HEDLEY_GCC_VERSION_CHECK(7,4,0) && !HEDLEY_GCC_VERSION_CHECK(8,0,0)) || HEDLEY_GCC_VERSION_CHECK(8,3,0)) | |||
There was a problem hiding this comment.
Can you move this logic to simde/simde-common.h by defining a SIMDE_BUG_GCC_87467 there?
See
Lines 973 to 976 in fdbd6b2
There was a problem hiding this comment.
Ah, I see. I will do so. Thanks!
mr-c
changed the title
_mm512{,_mask}_abs_pd
The gcc bug is described here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87467 It is fixed in versions 7.4.0 and 8.3.0 and above.
Head branch was pushed to by a user without write access
thomas-schlichter
force-pushed
the
master
branch
from
c5f7a00 to
7e931a6
Compare
|
Thank you @thomas-schlichter ; if you know of a project using SIMDe that can be listed publicly, it would be nice to add that to https://github.com/simd-everywhere/simde/wiki/Projects-Using-SIMDe |
|
Yes, OpenAirInterface (https://gitlab.eurecom.fr/oai/openairinterface5g/) is using it. It is quite a big project and we are just one of many contributors, so I don't know if I would have the right to add it there myself... ;-) |
That is really cool! I've gone and added it to the list myself. |
Fix check for gcc bug in abs.h .
The gcc bug is described here:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87467
It is fixed in versions 7.4.0 and 8.3.0 and above.