Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch] neon/st1{,q}_*_x{2,3,4}: initial implementation #1082

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

yyctw
Copy link
Contributor

@yyctw yyctw commented Oct 18, 2023

This PR is based on the previous PR and fixes the compiler error by adding a new macro SIMDE_BUG_GCC_REV_260989 (ref).

@mr-c mr-c enabled auto-merge (squash) October 18, 2023 09:22
@mr-c
Copy link
Collaborator

mr-c commented Oct 18, 2023

@yyctw About the test failure: there may be qemu bugs; Currently we are using a qemu-user-static package version 1:7.2+dfsg-1ubuntu0~22.04.sav0 from https://launchpad.net/~savoury1/+archive/ubuntu/virtualisation

That's quite far behind qemu 8.1.2 (the latest release).

So we'll need to either find a newer PPA or see if there is a free CI provider that we can do an armv7-a / arm-linux-gnueabihf (a.k.a. armhf in Debian/Ubuntu parlance) native build using clang-15 & test run.

One possibility of a newer PPA is https://launchpad.net/~aschultz/+archive/ubuntu/backports , but I don't know the person.

}
#if defined(SIMDE_ARM_NEON_A32V7_ENABLE_NATIVE_ALIASES)
#undef vst1_f32_x4
#define vst1_f32_x4(a, b) simde_vst1_f32_x4((a), (b))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit

Suggested change
#define vst1_f32_x4(a, b) simde_vst1_f32_x4((a), (b))
#define vst1_f32_x4(ptr, val) simde_vst1_f32_x4((ptr), (val))

simde/simde-common.h Show resolved Hide resolved
test/arm/neon/st1_x4.c Outdated Show resolved Hide resolved
@yyctw
Copy link
Contributor Author

yyctw commented Oct 18, 2023

@yyctw About the test failure: there may be qemu bugs; Currently we are using a qemu-user-static package version 1:7.2+dfsg-1ubuntu0~22.04.sav0 from https://launchpad.net/~savoury1/+archive/ubuntu/virtualisation

That's quite far behind qemu 8.1.2 (the latest release).

So we'll need to either find a newer PPA or see if there is a free CI provider that we can do an armv7-a / arm-linux-gnueabihf (a.k.a. armhf in Debian/Ubuntu parlance) native build using clang-15 & test run.

One possibility of a newer PPA is https://launchpad.net/~aschultz/+archive/ubuntu/backports , but I don't know the person.

Should we request permission or can we use this PPA directly?

@mr-c
Copy link
Collaborator

mr-c commented Oct 18, 2023

@yyctw About the test failure: there may be qemu bugs; Currently we are using a qemu-user-static package version 1:7.2+dfsg-1ubuntu0~22.04.sav0 from https://launchpad.net/~savoury1/+archive/ubuntu/virtualisation
That's quite far behind qemu 8.1.2 (the latest release).
So we'll need to either find a newer PPA or see if there is a free CI provider that we can do an armv7-a / arm-linux-gnueabihf (a.k.a. armhf in Debian/Ubuntu parlance) native build using clang-15 & test run.
One possibility of a newer PPA is https://launchpad.net/~aschultz/+archive/ubuntu/backports , but I don't know the person.

Should we request permission or can we use this PPA directly?

I would wait for the result of the SIMDE_ALIGN_TO_16 test; if that doesn't work then we can try the PPA directly

auto-merge was automatically disabled October 18, 2023 15:47

Head branch was pushed to by a user without write access

@yyctw yyctw force-pushed the fix_st1_x234 branch 2 times, most recently from 83dff0f to 5c48dee Compare October 18, 2023 15:53
@mr-c mr-c merged commit 879d1a0 into simd-everywhere:master Oct 18, 2023
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants