NEON: more fp16 using intrinsics supported by architecture v7 (skip version) #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyctw
force-pushed
the
v7_without_compiler_bugs
branch
from
9341801 to
e895c43
Compare
mr-c
reviewed
Oct 17, 2023
mr-c
reviewed
Oct 17, 2023
mr-c
reviewed
Oct 17, 2023
| SIMDE_CONSTIFY_8_(vget_lane_f16, r, (HEDLEY_UNREACHABLE(), SIMDE_FLOAT16_VALUE(0.0)), lane, v); | ||
| SIMDE_CONSTIFY_8_(vgetq_lane_f16, r, (HEDLEY_UNREACHABLE(), SIMDE_FLOAT16_VALUE(0.0)), lane, v); |
There was a problem hiding this comment.
Odd, the tests already covered lane values above 3; why didn't that cause a problem already?
@yyctw Can you take a look at
simde/test/arm/neon/get_lane.c
Lines 505 to 518 in d08d67c
There was a problem hiding this comment.
Based on my previous conclusion [ref], even if the HEDLEY_UNREACHABLE() is executed during the testing process (when lane > 3), it will not cause the test to fail.
mr-c
reviewed
Oct 17, 2023
Comment on lines
+57
to
+60
| simde_float16x4x2_t s_ = { { simde_float16x4_from_private(a_[0]), | ||
| simde_float16x4_from_private(a_[1]) } }; | ||
| return s_; | ||
| #endif |
There was a problem hiding this comment.
On the x86 side we would have something like a simde_float16x4x2_private typedef union with simde_float16x4 and simde_float16x4_private fields.
vmulh_lane_f16, vmulh_laneq_f16, vmul_lane_f16, vmul_laneq_f16, vmulq_laneq_f16.
Modified wrong implementation "Ties to Away" to "rounding to nearest with ties to Away" add.h: Remove redundant code.
one ld2_f16, twenty-two ld2_lane series, and twenty-two ld2_dup series.
yyctw
force-pushed
the
v7_without_compiler_bugs
branch
from
e895c43 to
d5c2855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, this is Eric from Andes Technology Corporation.
This PR is based on the previous PR with certain functions removed to avoid triggering compiler bugs.