Extend constant range in simde_vshll_n_XXX intrinsics #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAICS the only failure is the compilation of all the n=0 cases with gcc 12 on armv7. |
|
It looks like gcc bug, but when I try vshll_n_XXX intrinsics with zero shift in Compiler Explorer, it compiles correctly with ARM GCC 12.3.0 (other versions too), so I'm not sure why it doesn't compile here. |
|
My mistake, Compiler Explorer doesn't compile the resulting code, that's why there's no error. |
|
I filed a bug with gcc. |
|
Thank you @M-HT . Now that we have a bug number, can you add a workaround that disables that test? |
|
@mr-c This is hopefully what you had in mind. |
mr-c
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends constant range in simde_vshll_n_XXX intrinsics according to #1064, including tests for new values.