ENH Add generic types #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/2/add-generics
branch
2 times, most recently
from
55a86f1
to
da12f4f
Compare
emteknetnz
requested changes
Jan 18, 2024
src/Versioned.php
Outdated
| * @mixin RecursivePublishable | ||
| * | ||
| * @extends DataExtension<DataObject&RecursivePublishable&Versioned> |
There was a problem hiding this comment.
Suggested change
| * @extends DataExtension<DataObject&RecursivePublishable&Versioned> | |
| * @extends DataExtension<DataObject&RecursivePublishable&static> |
src/Versioned.php
Outdated
| * @param string $stage The name of the stage. | ||
| * @param string $filter A filter to be inserted into the WHERE clause. | ||
| * @param boolean $cache Use caching. | ||
| * @param string $sort A sort expression to be inserted into the ORDER BY clause. | ||
| * | ||
| * @return DataObject | ||
| * @return T&Versioned |
There was a problem hiding this comment.
Suggested change
| * @return T&Versioned | |
| * @return T&static |
src/Versioned.php
Outdated
| * @param int $id | ||
| * @return DataObject | ||
| * @return T&Versioned |
There was a problem hiding this comment.
Suggested change
| * @return T&Versioned | |
| * @return T&static |
GuySartorelli
force-pushed
the
pulls/2/add-generics
branch
from
da12f4f
to
1637059
Compare
emteknetnz
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/silverstripe-framework#11108 for these generics to take effect.
Issue