Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Explicity mark nullable parameters for PHP 8.4 #1352

Merged
merged 1 commit into from
Dec 2, 2024
Merged

API Explicity mark nullable parameters for PHP 8.4 #1352

merged 1 commit into from
Dec 2, 2024
+5 −5

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Nov 28, 2024
Closed
2 tasks
@emteknetnz emteknetnz marked this pull request as ready for review December 2, 2024 20:38
GuySartorelli
GuySartorelli approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 2ba31fb into silverstripe:7 Dec 2, 2024
13 checks passed
@GuySartorelli GuySartorelli deleted the pulls/7/php84 branch December 2, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli