Merge pull request #611 from xini/fix-multioptionfields

fix default values for EditableMultipleOptionField subclasses, fixes #610
silverstripe · Jun 13, 2017 · fe98baf · fe98baf
2 parents 802c750 + 4b26692
commit fe98baf
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/code/model/editableformfields/EditableCheckboxGroupField.php b/code/model/editableformfields/EditableCheckboxGroupField.php
@@ -22,7 +22,7 @@ public function getFormField()
         // Set the default checked items
         $defaultCheckedItems = $this->getDefaultOptions();
         if ($defaultCheckedItems->count()) {
-            $field->setDefaultItems($defaultCheckedItems->map('EscapedTitle')->keys());
+            $field->setDefaultItems($defaultCheckedItems->map('Value')->keys());
         }
 
         $this->doUpdateFormField($field);

diff --git a/code/model/editableformfields/EditableDropdown.php b/code/model/editableformfields/EditableDropdown.php
@@ -38,7 +38,7 @@ public function getFormField()
         // Set default
         $defaultOption = $this->getDefaultOptions()->first();
         if ($defaultOption) {
-            $field->setValue($defaultOption->EscapedTitle);
+            $field->setValue($defaultOption->Value);
         }
         $this->doUpdateFormField($field);
         return $field;

diff --git a/code/model/editableformfields/EditableOption.php b/code/model/editableformfields/EditableOption.php
@@ -75,12 +75,16 @@ public function canDelete($member = null)
 		return $this->canEdit($member);
 	}
 
+	/**
+	 * @deprecated 5.0 Use "$Title.XML" in templates instead
+	 * @return string
+	 */
     public function getEscapedTitle()
     {
 		return Convert::raw2att($this->Title);
 	}
 
-    /**
+	/**
      * @param Member $member
      * @return bool
      */

diff --git a/code/model/editableformfields/EditableRadioField.php b/code/model/editableformfields/EditableRadioField.php
@@ -34,7 +34,7 @@ public function getFormField()
         // Set default item
         $defaultOption = $this->getDefaultOptions()->first();
         if ($defaultOption) {
-            $field->setValue($defaultOption->EscapedTitle);
+            $field->setValue($defaultOption->Value);
         }
         $this->doUpdateFormField($field);
         return $field;