Merge pull request #1000 from creative-commoners/pulls/5.6/submit-error

FIX Check hidden inputs exist to prevent browser alert when submitting form
silverstripe · Sep 2, 2020 · 1623195 · 1623195
2 parents d82bb6b + f5d07aa
commit 1623195
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/client/dist/js/userforms.js b/client/dist/js/userforms.js
diff --git a/client/src/bundles/UserForms.js b/client/src/bundles/UserForms.js
@@ -530,8 +530,10 @@ jQuery(document).ready(($) => {
 
       if (isValid) {
         // Remove required attributes on hidden fields
-        $(form).find('.field.requiredField.hide input')
-          .removeAttr('required aria-required data-rule-required').valid();
+        const hiddenInputs = $(form).find('.field.requiredField.hide input');
+        if (hiddenInputs.length > 0) {
+          hiddenInputs.removeAttr('required aria-required data-rule-required').valid();
+        }
 
         // When using the "are you sure?" plugin, ensure the form immediately submits.
         $(form).removeClass('dirty');