Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize classname for has_one relations #93

Open
wants to merge 1 commit into
base: 2
Choose a base branch
from
Open

Sanitize classname for has_one relations #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/DataFormatter/XMLDataFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,8 @@ public function convertDataObjectWithoutHeader(DataObject $obj, $fields = null,
if (!singleton($relClass)->stat('api_access')) {
continue;
}
// backslashes in FQCNs kills both URIs and XML
$relClass = $this->sanitiseClassName($relClass);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should be below this block? i.e. only sanitise it right before writing the URLs and XML?

// Field filtering
if ($fields && !in_array($relName, $fields)) {
    continue;
}
if ($this->customRelations && !in_array($relName, $this->customRelations)) {
    continue;
}


// Field filtering
if ($fields && !in_array($relName, $fields)) {
Expand Down