-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2: Update namespace, dependencies. Add PhoneLink & migration task #54
Conversation
173e961
to
f1c7ba8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall 👍 , found a couple of minor issues though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick code review and didn't see anything obviously wrong. I'm assuming that all of this code was more or less lifted from the v1 version of the module.
I tested that the core functionality of the module still works. I tested by adding a link to a page and by creating a Link block.
Didn't test the migration ... I don't have much context on how that other module work.
My main concern is what will happen with the data with the new table name?
0ab3a11
to
71c5053
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes 👍 I have one minor concern with the frontend assets linting but other than that it's looking really good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 👍 I'm happy with the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me happy!
Updating
master
(GraphQL 4) with important changes in1
(GraphQL 3)I think for a long time development was only being undertaken for the
1
branch, somaster
(which was effectively2
) has fallen quite far behind.Link
toLinkField
.PhoneLink
model.LinkableMigrationTask
.table_name
configuration.SiteTreeLink
should grabTitle
from its page, if no title is specified.What I didn't bring over
Testing
Page
has_one
Link::class
: tested within the page edit form.Page
has_many
LinkItem
, whichhas_one
Link
: tested within a GridField edit form.Issues with GridField edit form
Currently the scaffolded field seems to be a dropdown of existing
Link
models, rather than aLinkField
. I'm not sure why that is.I think this issue exists in the GraphQL 3 version as well, so probably doesn't have to be solved here.
The workaround is to remove the scaffolded field, and explicitly add a
LinkField
.