Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP Upgrade redux dependencies #358

Merged
merged 1 commit into from
Dec 17, 2024
Merged

DEP Upgrade redux dependencies #358

merged 1 commit into from
Dec 17, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Dec 16, 2024 •
edited
Loading

Issue silverstripe/.github#333

Note that yarn build was run, though there are no changes to bundle files

@emteknetnz emteknetnz mentioned this pull request Dec 16, 2024
Closed
1 task
@emteknetnz emteknetnz marked this pull request as ready for review December 16, 2024 20:49
@GuySartorelli
Copy link
Member

Note that yarn build was run, though there are no changes to bundle files

This is expected, as redux is included in the webpack externals so the version provided by silverstripe/admin is ultimately used.

GuySartorelli
GuySartorelli approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit bbb88e5 into silverstripe:5.0 Dec 17, 2024
16 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.0/redux branch December 17, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli