FIX Console warning about required type #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
emteknetnz
requested changes
Jan 10, 2024
src/Form/LinkField.php
Outdated
| @@ -44,7 +44,7 @@ protected function getDefaultAttributes(): array | |||
| { | |||
| $attributes = parent::getDefaultAttributes(); | |||
| $attributes['data-value'] = $this->Value(); | |||
| $attributes['data-can-create'] = $this->getOwner()->canEdit(); | |||
| $attributes['data-can-create'] = $this->getOwner()->canEdit() ? 'true' : 'false'; | |||
There was a problem hiding this comment.
I don't like the use of string booleans here, it gets confusing. Revert this and just do things how Silverstripe does them natively
src/Form/MultiLinkField.php
Outdated
| @@ -61,7 +61,7 @@ protected function getDefaultAttributes(): array | |||
| { | |||
| $attributes = parent::getDefaultAttributes(); | |||
| $attributes['data-value'] = $this->getValueArray(); | |||
| $attributes['data-can-create'] = $this->getOwner()->canEdit(); | |||
| $attributes['data-can-create'] = $this->getOwner()->canEdit() ? 'true' : 'false'; | |||
There was a problem hiding this comment.
Revert so that we're not using string booleans
| @@ -53,8 +53,8 @@ jQuery.entwine('ss', ($) => { | |||
| ownerRelation: inputField.data('owner-relation'), | |||
| onChange: this.handleChange.bind(this), | |||
| isMulti: this.data('is-multi') ?? false, | |||
| types: this.data('types') ?? [], | |||
| canCreate: this.getInputField().data('can-create') ?? false, | |||
| types: this.data('types') ?? {}, | |||
There was a problem hiding this comment.
Revert so that we're not using string booleans
There was a problem hiding this comment.
I leave this part with new changes.
There was a problem hiding this comment.
If canEdit() returns true, then data-can-create attribute exists and inputField.data('can-create') = data-can-create, if canEdit() returns false, then inputField.data('can-create') = undefined. So we can use this in JS to return true instead of return a string data-can-create.
sabina-talipova
force-pushed
the
pulls/4/fix-console-error
branch
from
f574157 to
23f49e1
Compare
emteknetnz
approved these changes
Jan 11, 2024
emteknetnz
requested changes
Jan 11, 2024
sabina-talipova
force-pushed
the
pulls/4/fix-console-error
branch
from
23f49e1 to
f22ce6d
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
types.If$this->getOwner()->canEdit()returns boolean value, then$attributes['data-can-create']is populated with'data-can-create'instead of boolean value. Now return string value.Parent issue