ENH Change clear text to delete #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Jan 8, 2024
|
I just had a thought - and feel free to say it's out of scope or not worth doing. But should this say "Archive" when links are versioned, and "Delete" when they're not? That is more accurate, but I'm on the fence as to whether it's valuable enough of a distinction to be worth adding the complexity. |
emteknetnz
force-pushed
the
pulls/4/clear
branch
from
9d204fc to
2086a38
Compare
|
Have added in archived text functionality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #149
Even though the ACs are to just change the text label, it also makes sense to change all references in the codebase from 'clear' to 'delete' so that we're not using two different word for the same thing