FIX Nicely truncate link title/URL #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/4/truncate-link-text
branch
from
9c5e614 to
88f1b7f
Compare
GuySartorelli
commented
Jan 8, 2024
There was a problem hiding this comment.
I ended up using https://css-tricks.com/flexbox-truncated-text/ as a guide for how to do this.
Comment on lines
-112
to
+114
| &::before { | ||
|
|
||
| &[class*="font-icon-"]::before { |
There was a problem hiding this comment.
Required to override existing styles due to specificity
emteknetnz
requested changes
Jan 8, 2024
|
By "spacing" I assume you mean the vertical alignment of the text, and not any horizontal padding or anything else? |
GuySartorelli
force-pushed
the
pulls/4/truncate-link-text
branch
from
88f1b7f to
d3ece30
Compare
|
Fixed vertical alignment of versioned badge |
emteknetnz
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works regardless of screen size - check with split view and in edit view.
Also check with "DRAFT", "MODIFIED", and published (no) versioned labels.
Before:
After:
Issue