make translatable & add german translations #109
Conversation
| @@ -36,4 +42,11 @@ public function getURL(): string | |||
| { | |||
| return $this->Email ? sprintf('mailto:%s', $this->Email) : ''; | |||
| } | |||
|
|
|||
| public function fieldLabels($includerelations = true) | |||
There was a problem hiding this comment.
This isn't necessary - there's a fallback to a dB namespaced translatable key which you'll surface in the yml file if you run the i18n text collector.
Same with all other field labels you're adding
There was a problem hiding this comment.
Hmm am I missing something, if I comment out fieldLabels function the translations are not applied.
There was a problem hiding this comment.
Did you run the i18n text collector over this module, and use the new translation keys it generates for your german translations?
|
Thanks for your interest in this module and for the contribution. |
|
Closing in favour of #119 Once v4 is closer to release we'll push the strings to transifex and you can add your German translations there. |
No description provided.