Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make link type labels and order consistent with WYSIWYG #40

Closed
purplespider opened this issue Nov 15, 2021 · 3 comments
Closed

Make link type labels and order consistent with WYSIWYG #40

purplespider opened this issue Nov 15, 2021 · 3 comments

Comments

@purplespider
Copy link

purplespider commented Nov 15, 2021

When adding a link to a page this module uses the terminology "Site Tree Link" in the UI, but I don't believe the term "Site Tree" is used anywhere else in the CMS.

For clarity and consistency can we make the terminology the same as when inserting a link via the WYSIWYG, e.g.:
Screenshot 2021-11-15 at 11 16 49@2x

Current linkfield module for comparison:
Screenshot 2021-11-15 at 11 17 11@2x

(I started trying to do this myself, but unfortunately I don't do React).

Acceptance criteria

  • The labels in the LinkField drop down are updated to match the equivalent label in the WYSIWYG drop down
    • "SiteTree Link" is updated to be "Page on this site".
  • The Link titles remain unchanged everywhere else.
  • The options in the LinkField drop down are displayed in the same order that they're in with the WYSIWYG drop down

PR

@purplespider purplespider changed the title Make field labels and order consistent with WYSIWYG Make link type labels consistent with WYSIWYG Nov 15, 2021
@purplespider
Copy link
Author

purplespider commented Oct 10, 2023

@maxime-rainville How can I get some eyes on this? Do you agree? Any potential complications?

@maxime-rainville
Copy link

We're doing a bunch of work on this right now. I've added this to the backlog.

@GuySartorelli GuySartorelli changed the title Make link type labels consistent with WYSIWYG Make link type labels and order consistent with WYSIWYG Dec 21, 2023
@sabina-talipova sabina-talipova self-assigned this Jan 11, 2024
@sabina-talipova sabina-talipova removed their assignment Jan 11, 2024
@GuySartorelli
Copy link
Member

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants