Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate linkfield improvements #84

Closed
emteknetnz opened this issue Sep 25, 2023 · 4 comments
Closed

Investigate linkfield improvements #84

emteknetnz opened this issue Sep 25, 2023 · 4 comments
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Sep 25, 2023

Holder card for potential linkfield improvement PRs

This implement some of what was talked about in these issues

I've made them all draft PRs and I've mainly only included code changes and not unit tests or docs, the intention being that we may not want some of the PRs and because there's an existing unmerged PR from Max to add multi-link support which may impact some of the draft PRs

We'll probably want to merge this old has_many PR Max did first as is, fix any broken tests and then rebase the other PRs and then take it for there

PRs

From there we'll also want to do the following:

  • Refactoring / tidy up
  • Ensure adequate test coverage
  • New readme
  • Add developer docs, including how to add custom links types or modify existing ones
  • Maybe look at UI to make it look more like the TinyMCE plugin

Other

@GuySartorelli
Copy link
Member

@maxime-rainville @emteknetnz This should not be unassigned

@emteknetnz emteknetnz self-assigned this Sep 28, 2023
@emteknetnz
Copy link
Member Author

Sorry accidentally assigned Max then unassigned him, should have just stayed on me, have reassigned myself)

@purplespider
Copy link

Linking to #40 re consistency with TinyMCE dropdown.

@maxime-rainville
Copy link

I've attached all the PR to relevant issues or closed them if they weren't relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants