Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation extension points #243

Merged

Conversation

mfendeksilverstripe
Copy link
Contributor

@mfendeksilverstripe mfendeksilverstripe commented Nov 26, 2019

  • several new extension points added
  • these extension points allow to execute some custom code related to handling of user actions
  • no functional changes apart from following fix
  • fixed an issue in Scaffolding/Scaffolders/CRUD/Delete.php where variable $info wasn't passed into a function callback which prevented an existing extension point from ever passing this data through
  • these changes are required for Action trigger feature silverstripe-versioned-snapshots#25

@@ -65,7 +65,7 @@ protected function generateInputType()

public function resolve($object, array $args, $context, ResolveInfo $info)
{
DB::get_conn()->withTransaction(function () use ($args, $context) {
DB::get_conn()->withTransaction(function () use ($args, $context, $info) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue where $info wasn't passed into the existing extension point.

Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@robbieaverill robbieaverill merged commit 0a9913f into silverstripe:3 Dec 14, 2019
unclecheese pushed a commit that referenced this pull request Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants