Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Refactor to not require sake #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

chillu
Copy link
Member

@chillu chillu commented Jun 13, 2021

There's no straightforward way to have sake run without a database connection.
When using a "fake" HTTPApplication for CLI execution, it executes middleware which rightfully assumes a database connection (e.g. fluent is getting available languages to modify routing).

Todo:

  • Remove error handlers assuming HTTP context (e.g. SERVER_PROTOCOL)
  • Test with composer v1
  • Test clean 4.x install
  • Test that it creates files in public/assets
  • Fix reliance of error handling on $_SERVER

Relies on silverstripe/silverstripe-framework#9977

Related:

There's no straightforward way to have sake run without a database connection.
When using a "fake" HTTPApplication for CLI execution, it executes middleware which rightfully assumes a database connection (e.g. fluent is getting available languages to modify routing).

Relies on silverstripe/silverstripe-framework#9977
@chillu
Copy link
Member Author

chillu commented Jun 27, 2021

Next frontier on this is error handling which relies on $_SERVER environment variables that don't exist outside of a HTTP context, and are currently mocked on CLI execution through HTTPRequestBuilder::createFromEnvironment().

@chillu chillu marked this pull request as ready for review July 1, 2021 02:33
@chillu chillu force-pushed the pulls/remove-sake-dep branch from 1fd544d to 23f9af3 Compare July 12, 2021 21:38
chillu and others added 2 commits July 13, 2021 09:42
autoload.php is generated *after* the plugin is first activated, but *before* the post-install and post-update hooks are called.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant