Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Use correct contructor for HTTPOutputHandler #11393

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Sep 19, 2024

Issue silverstripe/.github#305

Causes a mass of output on graphql unit tests which call $logger->info() alot, because instead of passing the injected 'notice' level, it uses the default 'debug' level instead.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit a81b785 into silverstripe:5 Sep 23, 2024
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/fix-constructor branch September 23, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants