Skip to content

Commit

Permalink
API Remove deprecation notice from method we're not removing (#11540)
Browse files Browse the repository at this point in the history
We can't remove this method, because it will still be inherited from
SingleSelectField.
  • Loading branch information
GuySartorelli authored Jan 9, 2025
1 parent 533c0eb commit bcdd1e2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 14 deletions.
12 changes: 0 additions & 12 deletions src/Forms/SearchableDropdownField.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,4 @@ public function __construct(
$this->addExtraClass('ss-searchable-dropdown-field');
$this->setHasEmptyDefault(true);
}

/**
* @param string $string
* @return $this
*
* @deprecated 5.2.0 Use setPlaceholder() instead
*/
public function setEmptyString($string)
{
Deprecation::notice('5.2.0', 'Use setPlaceholder() instead');
return parent::setEmptyString($string);
}
}
3 changes: 1 addition & 2 deletions src/Forms/SearchableDropdownTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,7 @@ public function getPlaceholder(): string
* Calling this will also call setHasEmptyDefault(true), if the method exists on the class,
* which is required for the placeholder functionality to work on SearchableDropdownField
*
* In the case of SearchableDropField this method should be used instead of setEmptyString() which
* will be remvoved in a future version
* In the case of SearchableDropField this method should be used instead of setEmptyString()
*/
public function setPlaceholder(string $placeholder): static
{
Expand Down

0 comments on commit bcdd1e2

Please sign in to comment.