Merge pull request #30 from creative-commoners/pulls/2/php84

API Explicity mark nullable parameters for PHP 8.4
silverstripe · Dec 2, 2024 · 990527a · 990527a
2 parents 4ef00cf + 7cc6c66
commit 990527a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Dispatch/EventDispatcherInterface.php b/src/Dispatch/EventDispatcherInterface.php
@@ -25,5 +25,5 @@ public function removeListener(string $eventName, EventHandlerInterface $listene
      * @param object $eventContext
      * @param string|null $eventName
      */
-    public function dispatch(object $eventContext, string $eventName = null): void;
+    public function dispatch(object $eventContext, ?string $eventName = null): void;
 }
diff --git a/src/Symfony/Event.php b/src/Symfony/Event.php
@@ -20,7 +20,7 @@ class Event implements EventContextInterface
      * @param string $action
      * @param array $properties
      */
-    public function __construct(string $action = null, array $properties = [])
+    public function __construct(?string $action = null, array $properties = [])
     {
         $this->event = new GenericEvent($action, $properties);
     }

diff --git a/tests/Dispatch/MockBackend.php b/tests/Dispatch/MockBackend.php
@@ -11,7 +11,7 @@ class MockBackend implements EventDispatcherInterface
 
     public $listeners = [];
 
-    public function dispatch(object $eventContext, string $eventName = null): void
+    public function dispatch(object $eventContext, ?string $eventName = null): void
     {
         $listeners = $this->listeners[$eventName] ?? [];
         foreach ($listeners as $listener) {