Skip to content

Commit

Permalink
Merge pull request #121 from creative-commoners/pulls/3/phpunit11
Browse files Browse the repository at this point in the history
DEP Use PHPUnit 11
  • Loading branch information
GuySartorelli authored Sep 18, 2024
2 parents 91846db + 78e0cfb commit b1bd749
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"silverstripe/vendor-plugin": "^2"
},
"require-dev": {
"phpunit/phpunit": "^9.6",
"phpunit/phpunit": "^11.3",
"squizlabs/php_codesniffer": "^3.7",
"silverstripe/standards": "^1",
"phpstan/extension-installer": "^1.3"
Expand Down
5 changes: 3 additions & 2 deletions tests/ErrorPageTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
use SilverStripe\ORM\ValidationException;
use SilverStripe\Versioned\Versioned;
use SilverStripe\View\SSViewer;
use PHPUnit\Framework\Attributes\DataProvider;

/**
* @package cms
Expand Down Expand Up @@ -223,8 +224,8 @@ public function testWriteStaticPageWithDisableStaticFile()
/**
* @param string $env
* @param bool $shouldShowInDev
* @dataProvider provideErrorMessageEnv
*/
#[DataProvider('provideErrorMessageEnv')]
public function testErrorMessageAppended($env, $shouldShowInDev)
{
/* @var Kernel $kernel */
Expand All @@ -247,7 +248,7 @@ public function testErrorMessageAppended($env, $shouldShowInDev)
/**
* @return array
*/
public function provideErrorMessageEnv()
public static function provideErrorMessageEnv()
{
return [
['dev', true],
Expand Down

0 comments on commit b1bd749

Please sign in to comment.