NEW Add content for 'Add Block' popover widget #371
Conversation
| this.handleLinkClick = this.handleLinkClick.bind(this); | ||
| } | ||
|
|
||
| handleLinkClick() { |
There was a problem hiding this comment.
This was removed right? There's still a few references to this stuff. Sad to see it go 😢
|
|
||
| AddElementPopoverContent.defaultProps = { | ||
| elementTypes: [ | ||
| { title: 'banner', icon: 'font-icon-block-banner' }, |
There was a problem hiding this comment.
The default props should not have test data in it any more
raissanorth
force-pushed
the
pulls/master/add-add-element-widget
branch
from
7c6e2f0 to
9844855
Compare
|
|
||
| return elementTypes.map((elementType) => | ||
| ( | ||
| <Button className={ |
There was a problem hiding this comment.
You will need to add a key= in here. There is an identifier (of sorts) on the elementType you can use.
|
|
||
| render() { | ||
| return ( | ||
| <div className="element-editor__add-element-popover-content"> |
There was a problem hiding this comment.
You're going to hate me for this one. I think we should refactor these class names. I'm terrible at this myself because BEM confuses me. It's supposed to be like this:
.block__element--modifier
Modifiers should only be things like --hidden or --disabled
We should probably refactor this so element-editor-add-element is the "block" and content is the "element". Ie. className="element-editor-add-element__content". And then for the next div className="element-editor-add-element__button-container".
raissanorth
force-pushed
the
pulls/master/add-add-element-widget
branch
from
9844855 to
202ab8a
Compare
This is the ground work for adding a popover to add a new 'Add Block' widget for the Elemental Editor. There is yet some work remaining, as decisions from the Style Council are still outstanding - see #370
There are also styling issues with Edge and IE, but these can be addressed as part of the ongoing work related to this feature:
The buttons are keyboard accessible on the latest versions of Edge, IE, Firefox, Chrome, and Safari.
Note that this does not return a popover itself, but the content that could be rendered within a Popover component.