SPIKE Inline validation

client/src/boot/registerTransforms.js

@@ -7,7 +7,6 @@ import addElementToArea from 'state/editor/addElementMutation';
 import ArchiveAction from 'components/ElementActions/ArchiveAction';
 import DuplicateAction from 'components/ElementActions/DuplicateAction';
 import PublishAction from 'components/ElementActions/PublishAction';
-import SaveAction from 'components/ElementActions/SaveAction';
 import UnpublishAction from 'components/ElementActions/UnpublishAction';
 
 export default () => {
@@ -75,7 +74,6 @@ export default () => {
 
   // Add elemental editor actions
   Injector.transform('element-actions', (updater) => {
-    updater.component('ElementActions', SaveAction, 'ElementActionsWithSave');
     updater.component('ElementActions', PublishAction, 'ElementActionsWithPublish');
     updater.component('ElementActions', UnpublishAction, 'ElementActionsWithUnpublish');
     updater.component('ElementActions', DuplicateAction, 'ElementActionsWithDuplicate');

client/src/components/ElementEditor/InlineEditForm.js

@@ -48,8 +48,12 @@ class InlineEditForm extends PureComponent {
     const classNames = classnames('element-editor-editform', extraClass);
     const schemaUrl = loadElementSchemaValue('schemaUrl', elementId);
 
+    // formTag needs to be a form rather than a div so that the php FormAction that turns into
+    // a <button type="submit>" submits this <form>, rather than the <form> for the parent page EditForm
+    const formTag = 'form';
+
     const formProps = {
-      formTag: 'div',
+      formTag,
       schemaUrl,
       identifier: 'element',
       refetchSchemaOnMount: !formHasState,
@@ -58,7 +62,8 @@ class InlineEditForm extends PureComponent {
       // FormBuilder forms, such as LinkField v4+, are themselves submitted
       // This FormBuilder form is not submitted in the traditional sense i.e. there is no rendered submit button
       // instead the inline save button will do its own submission in SaveAction.js
-      onSubmit: () => new Promise(resolve => resolve),
+      // onSubmit: () => new Promise(resolve => resolve),
+      // ^^ cannot use this if we do actually want to submit the form though :-)
     };
 
     if (loadingError) {