Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Import Deprecation class #3018

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Oct 22, 2024

Issue silverstripe/.github#320

Fixes https://github.com/silverstripe/silverstripe-framework/actions/runs/11451953139/job/31862038284?pr=11432#step:12:148

1) SilverStripe\Security\Tests\SecurityTest::testPermissionFailureSetsCorrectFormMessages Error: Class "SilverStripe\CMS\Controllers\Deprecation" not found /home/runner/work/silverstripe-framework/silverstripe-framework/vendor/silverstripe/cms/code/Controllers/ContentController.php:298

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 22, 2024

Please just add the use statement instead. This deprecated method will be removed in one of my PRs and it'll be easier for me to track things that way.

@emteknetnz emteknetnz changed the title API Remove deprecated method FIX Import Deprecation class Oct 22, 2024
@emteknetnz
Copy link
Member Author

Done

@GuySartorelli GuySartorelli merged commit f7b0f01 into silverstripe:6 Oct 22, 2024
11 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/remove-depr branch October 22, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants